Update travis conf by drobota · Pull Request #678 · robotframework/SeleniumLibrary

drobota · 2016-10-18T05:13:34Z

@aaltat, @HelioGuilherme66, @pekkaklarck please, have a look.

ombre42 · 2016-10-18T05:43:45Z

Increasing minimum version of selenium and also pegging to a specific version? This does not just affect CI but also where this library is installed or did I miss something?

drobota · 2016-10-18T05:49:04Z

Now selenium 2 library can only work with old Firefox driver which works only in firefox up to version 47.0.1 and selenium 2.53.6. We might need drop supporting it and switch to marionette(https://github.com/mozilla/geckodriver)

ombre42 · 2016-10-18T06:04:37Z

Understandable but pip can handle having a minimum and maximum version (I.e. range of compatible versions). Usually we try to give flexibility to the end user. Also I think a big change like selenium version should be mentioned in commit message and PR message IMHO.

aaltat · 2016-10-18T18:32:49Z

It should be possible to modify existing functionality in Open Browser keyword to support Firefox with and without the marionette. Also it should be possible to make the change in such manner that the it doesn't cause changes to the keyword signature.

I am thinking how to handle the change with the grid side. Should the keyword make some automatic setting with the desired capabilities or not. I am starting to think that we should not make any magic when user set the desired capabilities.

Therefore I am against changing the minimum required selenium version. Also the selenium 3 should be only drop in replacement for selenium 2 and it doesn't cause changes to the selenium API.

Of course we should recommended people to use latest selenium but we should not force it.

aaltat

One think which I do not fully grasp with Travis, where are those browsers opened? Are they opened by Travis or are they used with SauceLabs? Where those remote_url and the desired_capabilities are coming from?

aaltat · 2016-12-07T10:18:02Z

+  global:
+    - secure: "QyY0j8C+hVhsGLv4YU0UMvLm5wBDg6xT5J0Ee77C/JAQ6vcdCMpTfWI8oDxTZb7pBhpDkYuNe747yCYF5PrdBYQbO08FilxctReuJfMXcH44rZC5q49mUmPamkvg1LkzIWuC1s9uKnjlvyDT5ojuPXZl2Vn0gIhSIg+yOyBkM1U="
+    - secure: "HJaJTYauaBZODMDkbnRVsiCk+t2uVtztkkJ5V4dXSnE1uIBms2PVbufQwb+YNvzHkGheLtpnt/hLM1HhmSFgUtOCf+eumQ6kaLR2KRVEysXwWJzgZoLBidNBOy5rvAIsc9JJbDaIgYVGzyaJGTP9AMb8CyvIPE//lH10sf+GB7g="
+matrix:


Should we add some run with Python 3 too. Example have to runs with Chrome one with Python 2.7 and another one with Python 3.

I can add it, but does s2l compatible with py3?

No it is not yet compatible. But the aim for the 2.0 release, which hopefully is the next release, is to make it compatible with Python 3.

aaltat · 2016-12-07T10:21:18Z

@@ -1,3 +1,3 @@
 decorator >= 3.3.2
-selenium >= 2.32.0
+selenium == 2.53.6


Despite my previous comments, I think this change is OK, specially with the selenium 3. Supporting old version of selenium would need extra runs from the CI and in the current model, we do not have resource to provide the support and we do not have resources to pay for the CI time (or actually pay for the cloud service to get all the browsers running)

But instead selenium == 2.53.6 should we say selenium >= 2.53.6

aaltat · 2016-12-07T10:24:01Z

-  #- BROWSER=ie # will be added when we have completed SauceLabs CI
-  #- BROWSER=safari # will be added after #247 merged
+  global:
+    - secure: "QyY0j8C+hVhsGLv4YU0UMvLm5wBDg6xT5J0Ee77C/JAQ6vcdCMpTfWI8oDxTZb7pBhpDkYuNe747yCYF5PrdBYQbO08FilxctReuJfMXcH44rZC5q49mUmPamkvg1LkzIWuC1s9uKnjlvyDT5ojuPXZl2Vn0gIhSIg+yOyBkM1U="


Are the Sauce Labs hash keys to access the account. You have the clear passwords saved in somewhere? Perhaps we should distribute the password with wider audience but not put the passwords in git repo.

Is there reason why the are two secure lines?

Yes, these are encoded login and password for sauce labs. They can be securely stored in repo because they can be decoded only in travis env.

OK, this is good to go then.

aaltat · 2016-12-07T10:59:36Z

+            self._current_browser()).\
+            move_to_element(element).\
+            move_by_offset(xoffset, yoffset)\
+            .click().perform()


It could be cleaner to write:
action = ActionChains(self._current_browser())
action.move_to_element(element)
action.move_by_offset(xoffset, yoffset)
action.click().perform()

aaltat · 2016-12-07T11:00:17Z

    def page_should_contain_image(self, locator, message='', loglevel='INFO'):
        """Verifies image identified by `locator` is found from current page.
-
        See `Page Should Contain Element` for explanation about `message` and


I think empty line should have not been removed.

aaltat · 2016-12-07T11:02:21Z

 Create Webdriver Creates Functioning WebDriver
    [Documentation]    LOG 2:1 INFO REGEXP: Creating an instance of the \\w+ WebDriver
    ...    LOG 2:4 DEBUG REGEXP: Created \\w+ WebDriver instance with session id (\\w|-)+
+    [Tags]  Known Issue Chrome    Known Issue Internet Explorer    Known Issue Safari


Should we document the tags we use, so that people contributing could also use them right?

drobota force-pushed the ci branch from 1c7d81f to dca891a Compare October 18, 2016 05:44

drobota force-pushed the ci branch 3 times, most recently from 1b1d828 to ba0e431 Compare October 20, 2016 02:04

aaltat requested changes Dec 7, 2016

View reviewed changes

aaltat added the HIGH PRIORITY label Dec 7, 2016

Update travis conf

1e84596

drobota force-pushed the ci branch from ba0e431 to 1e84596 Compare December 9, 2016 06:19

aaltat approved these changes Dec 10, 2016

View reviewed changes

aaltat merged commit a2b3df4 into master Dec 10, 2016

aaltat mentioned this pull request Dec 10, 2016

Extend existing ci configuration #621

Closed

aaltat deleted the ci branch February 18, 2017 22:04

Conversation

drobota commented Oct 18, 2016

Uh oh!

ombre42 commented Oct 18, 2016

Uh oh!

drobota commented Oct 18, 2016

Uh oh!

ombre42 commented Oct 18, 2016

Uh oh!

aaltat commented Oct 18, 2016

Uh oh!

aaltat left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

drobota Dec 9, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

drobota Dec 9, 2016 •

edited

Loading